Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOCOM-1823,IOCOM-1826] FIMS history get saga and header component tests #6593

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[IOCOM-1823,IOCOM-1826] FIMS history get saga and header component tests #6593

wants to merge 5 commits into from
+612 −1

Conversation

forrest57
Copy link
Contributor

Short description

addition of said unit tests

List of changes proposed in this pull request

  • addition of tests for handleGetFimsHistorySaga
  • addition of tests for FimsHIstoryHeaderComponent, with its own snapshot

How to test

all tests should pass

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025 •
edited
Loading

Jira Pull Request Link

This Pull Request refers to Jira issues:
- Link to IOCOM-1823
- Link to IOCOM-1826

@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.36%. Comparing base (b207270) to head (c98a031).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6593      +/-   ##
==========================================
+ Coverage   49.30%   49.36%   +0.05%     
==========================================
  Files        1565     1565              
  Lines       32223    32223              
  Branches     7288     7336      +48     
==========================================
+ Hits        15887    15906      +19     
+ Misses      16298    16268      -30     
- Partials       38       49      +11
Files with missing lines Coverage Δ
...ures/fims/history/saga/handleGetFimsHistorySaga.ts 100.00% <100.00%> (+90.00%) ⬆️

... and 12 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c8f237...c98a031. Read the comment docs.

Vangaorth
Vangaorth requested changes Jan 10, 2025
View reviewed changes
ts/features/fims/history/components/__tests__/FimsHistoryHeaderComponent.test.tsx
const renderComponent = () =>
renderScreenWithNavigationStoreContext<GlobalState>(
FimsHistoryHeaderComponent,
"DUMMY",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put the real navigation route here?

ts/features/fims/history/saga/__tests__/handleGetFimsHistorySaga.test.ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also need to check for proper parameters on the instance passed to getFimsHistory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vangaorth Vangaorth Vangaorth requested changes

@ChrisMattew ChrisMattew Awaiting requested review from ChrisMattew ChrisMattew is a code owner

@gispada gispada Awaiting requested review from gispada gispada is a code owner

@freddi301 freddi301 Awaiting requested review from freddi301 freddi301 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
IO-Comunicazione
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forrest57 @Vangaorth